Setup network module #3
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| package di | ||
|
|
||
| val appModule = listOf( | ||
| networkModule | ||
| ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /build |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| import org.jetbrains.kotlin.gradle.ExperimentalKotlinGradlePluginApi | ||
| import org.jetbrains.kotlin.gradle.dsl.JvmTarget | ||
|
|
||
| plugins { | ||
| alias(libs.plugins.kotlinMultiplatform) | ||
| alias(libs.plugins.androidLibrary) | ||
| alias(libs.plugins.detekt) | ||
| alias(libs.plugins.ksp) | ||
| alias(libs.plugins.ktorfit) | ||
| } | ||
|
Comment on lines
+4
to
+10
There was a problem hiding this comment. Tip Codebase Verification The
Analysis chainEnsure that all plugins, especially Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify the application of plugins in the network module.
# Test: Search for plugin configurations in the network module. Expect: Correct plugin settings.
rg --type kotlin "plugins" core/network/build.gradle.kts
Length of output: 240 Script: #!/bin/bash
# Description: Verify the necessity of ksp and ktorfit plugins in the network module.
# Test: Search for usage of ksp in the network module. Expect: References to ksp.
rg --type kotlin "ksp" core/network/
# Test: Search for usage of ktorfit in the network module. Expect: References to ktorfit.
rg --type kotlin "ktorfit" core/network/
Length of output: 354 |
||
|
|
||
| kotlin { | ||
| androidTarget { | ||
| @OptIn(ExperimentalKotlinGradlePluginApi::class) | ||
| compilerOptions { | ||
| jvmTarget.set(JvmTarget.JVM_11) | ||
| } | ||
| } | ||
|
|
||
| listOf( | ||
| iosX64(), | ||
| iosArm64(), | ||
| iosSimulatorArm64() | ||
| ).forEach { iosTarget -> | ||
| iosTarget.binaries.framework { | ||
| isStatic = true | ||
| } | ||
| } | ||
|
|
||
| sourceSets { | ||
| commonMain.dependencies { | ||
| implementation(libs.koin.core) | ||
| implementation(libs.koin.compose) | ||
|
|
||
| implementation(libs.ktor.core) | ||
| implementation(libs.ktor.logging) | ||
| implementation(libs.ktor.serialization) | ||
| implementation(libs.ktor.negotiation) | ||
| api(libs.ktorfit) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| dependencies { | ||
| detektPlugins(libs.detekt.formatting) | ||
| } | ||
|
|
||
| android { | ||
| namespace = "io.heroesofcode.network" | ||
| compileSdk = libs.versions.android.compileSdk.get().toInt() | ||
| defaultConfig { | ||
| minSdk = libs.versions.android.minSdk.get().toInt() | ||
| } | ||
| compileOptions { | ||
| sourceCompatibility = JavaVersion.VERSION_11 | ||
| targetCompatibility = JavaVersion.VERSION_11 | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| package di | ||
|
|
||
| import de.jensklingenberg.ktorfit.Ktorfit | ||
| import io.ktor.client.HttpClient | ||
| import io.ktor.client.plugins.contentnegotiation.ContentNegotiation | ||
| import io.ktor.client.plugins.logging.LogLevel | ||
| import io.ktor.client.plugins.logging.Logging | ||
| import io.ktor.serialization.kotlinx.json.json | ||
| import kotlinx.serialization.ExperimentalSerializationApi | ||
| import kotlinx.serialization.json.Json | ||
| import org.koin.dsl.module | ||
|
|
||
| const val BASE_URL = "https://example.com" | ||
|
|
||
| @OptIn(ExperimentalSerializationApi::class) | ||
| val networkModule = module { | ||
| single { | ||
| HttpClient { | ||
| install(Logging) { | ||
| level = LogLevel.ALL | ||
| } | ||
|
Comment on lines
+19
to
+21
There was a problem hiding this comment. Tip Codebase Verification The search results confirm that there are no environment-based configurations for logging levels in the codebase. The logging level is set to
Analysis chainConsider adjusting the logging level or making it configurable based on the environment. Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify if there are environment-based configurations for logging levels.
# Test: Search for environment checks around logging configurations. Expect: Conditional logic based on environment.
rg --type kotlin "LogLevel" core/network/src/commonMain/kotlin/di/networkModule.kt
Length of output: 166 Script: #!/bin/bash
# Description: Verify if there are environment-based configurations for logging levels across the entire codebase.
# Test: Search for environment checks around logging configurations. Expect: Conditional logic based on environment.
rg --type kotlin "LogLevel"
Length of output: 221 |
||
|
|
||
| install(ContentNegotiation) { | ||
| json( | ||
| Json { | ||
| explicitNulls = false | ||
| ignoreUnknownKeys = true | ||
| isLenient = true | ||
| prettyPrint = true | ||
| encodeDefaults = true | ||
| classDiscriminator = "#class" | ||
| } | ||
| ) | ||
| } | ||
|
Comment on lines
+23
to
+34
There was a problem hiding this comment. Review the necessity of Json settings such as |
||
| } | ||
| } | ||
|
|
||
| single { | ||
| val httpClient: HttpClient = get() | ||
|
|
||
| Ktorfit.Builder() | ||
| .httpClient(httpClient) | ||
| .baseUrl(BASE_URL) | ||
| .build() | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,5 +29,4 @@ dependencyResolutionManagement { | |
| } | ||
|
|
||
| include(":composeApp") | ||
| include(":core:network") | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip
Codebase Verification
The search results indicate that the
kspplugin is included in multiplebuild.gradle.ktsfiles, but there is no evidence of its usage in the Kotlin source files. This suggests that thekspplugin might not be necessary for the Compose app.build.gradle.kts:alias(libs.plugins.ksp) apply falsecore/network/build.gradle.kts:alias(libs.plugins.ksp)composeApp/build.gradle.kts:alias(libs.plugins.ksp)Given this information, it appears that the
kspplugin is not actively used in the codebase.Analysis chain
Verify the necessity of the
kspplugin in the Compose app. Ensure it is used effectively.Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 78
Script:
Length of output: 386
Script:
Length of output: 193