Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify CI #257

Merged
merged 7 commits into from
Jan 3, 2022
Merged

Simplify CI #257

merged 7 commits into from
Jan 3, 2022

Conversation

mkroening
Copy link
Member

Replaces #129.

@codecov
Copy link

codecov bot commented Dec 16, 2021 •
edited
Loading

Codecov Report

Merging #257 (34287ce) into master (da544c6) will not change coverage.
The diff coverage is n/a.

❗ Current head 34287ce differs from pull request most recent head 004bd67. Consider uploading reports for the commit 004bd67 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #257   +/-   ##
=======================================
  Coverage   63.50%   63.50%           
=======================================
  Files          17       17           
  Lines        2458     2458           
=======================================
  Hits         1561     1561           
  Misses        897      897
Impacted Files Coverage Δ
src/vm.rs 78.78% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da544c6...004bd67. Read the comment docs.

@mkroening mkroening force-pushed the simple-ci branch 3 times, most recently from 6255774 to dd0395b Compare December 16, 2021 22:54
@mkroening mkroening marked this pull request as ready for review December 17, 2021 17:05
@mkroening mkroening requested a review from jounathaen December 17, 2021 17:07
@mkroening
Copy link
Member Author

@jounathaen, this should address most ideas of #129, except for 86c4f94. Is running CI in docker still a goal? If so, you could create an issue and we address the other points with this PR first.

This also does not remove running rusty_demo in CI, like your PR did. What do you think about that?

@jounathaen
Copy link
Member

LGTM! Indeed, I think running it all in docker would be beneficial. If you could open an issue, we can bors this. 👍

@mkroening mkroening self-assigned this Jan 3, 2022
@mkroening mkroening marked this pull request as draft January 3, 2022 15:40
@mkroening mkroening force-pushed the simple-ci branch 3 times, most recently from cd7fb54 to 5dfeaec Compare January 3, 2022 17:20
@mkroening mkroening marked this pull request as ready for review January 3, 2022 17:37
@mkroening mkroening mentioned this pull request Jan 3, 2022
Open
@mkroening
Copy link
Member Author

I opened #271 and rebased on latest master. 49a2fbd was implemented as 91d6a2e4acf91ba0040113cc6cca5025d824b6ed.

@mkroening
Copy link
Member Author

I extracted the OS-independent clippy-test-kernel job.

@mkroening
Copy link
Member Author

bors r=jounathaen

@bors
Copy link
Contributor

bors bot commented Jan 3, 2022

Build succeeded:

@bors bors bot merged commit d46a674 into hermit-os:master Jan 3, 2022
@mkroening mkroening deleted the simple-ci branch January 3, 2022 18:42
@mkroening mkroening mentioned this pull request Jan 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jounathaen jounathaen jounathaen left review comments

Assignees

@mkroening mkroening

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkroening @jounathaen