Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid using asserts #183

Closed
wants to merge 1 commit into from
Closed

avoid using asserts #183

wants to merge 1 commit into from

Conversation

stlankes
Copy link
Collaborator

@stlankes stlankes commented Sep 4, 2021

for some reasons, the assert doesn't work in this context.
A workaround is using a simple if-statement instead.

@stlankes stlankes requested a review from mkroening September 4, 2021 15:26
for some reasons, the assert doesn't work in this context.
A workaround is using a simple if-statement instead.
@codecov
Copy link

codecov bot commented Sep 4, 2021

Codecov Report

Merging #183 (ef037b2) into master (6ff81f4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #183   +/-   ##
=======================================
  Coverage   30.76%   30.76%           
=======================================
  Files          16       16           
  Lines        4017     4017           
=======================================
  Hits         1236     1236           
  Misses       2781     2781           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ff81f4...ef037b2. Read the comment docs.

Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my bad!

I accidentally changed the behavior in fa62a6d#diff-9940bd2f66049a07423515adc7f6c054b3bb7bdd260b59b3b74e1f3007c0830cL680.

This change is semantic and has nothing to do with assert.

Instead, it should be:

assert!(!input, "Invalid I/O operation");

@mkroening mkroening mentioned this pull request Sep 6, 2021
@bors bors bot closed this in 095579f Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants