scm/github: filter issues that belongs to PR diff #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following up on this so quickly! |
|
@adenisonafifi no problem, I was adding tests to be sure it won't break. Worth a star ⭐ haha |
Codecov Report
@@ Coverage Diff @@
## main #9 +/- ##
==========================================
- Coverage 74.04% 73.92% -0.12%
==========================================
Files 4 4
Lines 235 257 +22
==========================================
+ Hits 174 190 +16
- Misses 42 46 +4
- Partials 19 21 +2
Continue to review full report at Codecov.
|
| } | ||
|
|
||
| if len(comments) == 0 { | ||
| return errors.New("failed to find relevant issues") | ||
| } | ||
|
|
||
| body := fmt.Sprintf(`:wave: Hey, I added %d comments about your changes, please take a look :slightly_smiling_face:`, len(issues)) |
There was a problem hiding this comment.
@herlon214 I forgot to update the I added %d comments about your changes to use len(comments) as now the len(issues) >= len(comments)
There was a problem hiding this comment.
Fixed on v0.5.1, thanks @adenisonafifi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue #8