Add shared focus dependency parsing （增加国策树渲染时的共享国策依赖解析） #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herbix
reviewed
Sep 8, 2024
src/util/dependency.ts
Outdated
| @@ -30,6 +32,27 @@ export function getDependenciesFromText(text: string): Dependency[] { | |||
| match = regex.exec(text); | |||
| } | |||
|
|
|||
| if (sharedFocusIndex){ | |||
There was a problem hiding this comment.
不建议直接改 getDependenciesFromText 这个函数，这个函数是所有preview共用的。
比较好的做法是去改 previewdef/focustree/loader.ts。
而且相比用正则匹配，你可以用 convertNodeToJson() 这个方法得到比较准确的值。这样可以避免有人在注释里面或者文本里面写 shared_focus = blabla。
There was a problem hiding this comment.
哦哦我给忘了，之前看数据的时候看到了focuses里有shared focus的键来着
There was a problem hiding this comment.
把增量解析依赖文件的逻辑改到previewdef/focustree/loader.ts里了
herbix
reviewed
Sep 10, 2024
src/previewdef/focustree/loader.ts
Outdated
| @@ -17,7 +19,25 @@ export class FocusTreeLoader extends ContentLoader<FocusTreeLoaderResult> { | |||
| if (error || (content === undefined)) { | |||
| throw error; | |||
| } | |||
|
|
|||
|
|
|||
| const file = convertFocusFileNodeToJson(parseHoi4File(content, localize('infile', 'In file {0}:\n', this.file)),{}); | |||
herbix
reviewed
Sep 10, 2024
src/previewdef/focustree/loader.ts
Outdated
| } | ||
| const filePath = findFileByFocusKey(sharedFocus); | ||
| if (filePath){ | ||
| if(dependencies.findIndex((item) => item.path === filePath) === -1){ |
|
嗯嗯，以上的问题都改完了。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Controlled by
sharedFocusIndexfeature flag, default istrue由
sharedFocusIndexfeature flag控制，默认为true