Fixes saving of Keypad modifier keys in settings #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... seems like I referenced the wrong issue :( it fixes #4 - sorry! |
larpon
force-pushed
the
fix/saving-of-keypad-modifier-keys
branch
from
26a138b to
144c58b
Compare
|
Awesome @larpon , going to QA test this when i reach home. 👍 |
|
Cool - I found out I couldn't use custom values as this would corrupt the Settings on read/write - which makes sense in a way :) |
|
Nice, tested out the keymaping settings for the canvas rotate and sure enough i was able to assign and save my new keybinding and override the prevs default bindings. 👌 |
azagaya
pushed a commit
to azagaya/AnimeEffects
that referenced
this pull request
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
I was mapping custom values instead of using the correct Qt enums.