Add theme support #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… setting to onThemeUpdated slots
Fix conflict in src/ctrl/time/time_Renderer.cpp as the setting name has changed
…Introduce theme::TimeLine proxy for sending Qt stylesheet changes to non-QWidget derived classes
|
@herace - you should probably squash this into one commit. In case we want to roll things back at some point? |
|
oh wow, excellent work @larpon, Im going to Peer review this 👍 |
|
Cool, its really nice to have to themes on AE. Great stuff man 👍 |
|
Awesome! There's still room for improvement, but it's a start. We could also provide a custom dark theme maybe (so you don't have to have a dark system theme to get a dark AE theme) |
|
Yeah, since now the foundation is established putting themes will be less a hassle and of course later on there will be a dark theme. This merge is definitely good stuff 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add theme support including support for customizations and tweaks.
Features