Correctly handle errors from server #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As referenced in #1. |
|
The merge button never loads on my phone or I'd merge it right now. |
Previously we would treat errors as non-errors and then crash trying to parse the error data.
brianmay
force-pushed
the
handle_server_errors
branch
from
cc7f80f to
76f3874
Compare
|
I fixed the conflicts. |
|
I assumed you had with that last push. I'll merge when I'm not out on my phone, because all GitHub gives me is a spinning circle instead of a status and merge option:
|
|
Will you also push an update to npm? |
|
Yes. Not sure when though. You can install via github however... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would treat errors as non-errors and then crash trying to parse the error data.