forked from luisbrito/api.js
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixing BasicAuth due to missing btoa().
- Loading branch information
Showing
1 changed file
with
10 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah, you're right, it's weird to have this code here, checking globals to see if it will use the browser's or node's version of binary encoding.
It'd feel better if you did something similar to what you did with io here. Making this include a module (maybe Btoa.js?) that is properly configured inside node.js and browser.js to use the right function.