Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jvm): Return DoubleEndedIterator for InstructionList. #15

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

dload0
Copy link
Contributor

@dload0 dload0 commented Oct 11, 2024

A small quality of life for InstructionList. Removes the need for unnecessary clones in some use cases (for using .rev() on borrowed instances).

Doesn't affect existing code, however I'm not used to API building, so feel free to shoot this down. 😄

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.94%. Comparing base (bb84684) to head (0b97d2a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #15   +/-   ##
=======================================
  Coverage   77.93%   77.94%           
=======================================
  Files          51       51           
  Lines        5329     5331    +2     
  Branches     5329     5331    +2     
=======================================
+ Hits         4153     4155    +2     
  Misses        534      534           
  Partials      642      642           
Flag Coverage Δ
integration_tests 61.20% <100.00%> (+0.01%) ⬆️
unit_tests 25.45% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryhchchc
Copy link
Owner

Thanks for your contribution. I think we can try DoubleEndedIterator + ExactSizeIterator.

@dload0 dload0 force-pushed the feat/instruction-list-iterator branch from 06ca483 to 0b97d2a Compare October 14, 2024 19:22
@henryhchchc henryhchchc enabled auto-merge (rebase) October 15, 2024 01:07
@henryhchchc henryhchchc self-requested a review October 15, 2024 01:07
Copy link
Owner

@henryhchchc henryhchchc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks a lot for your contribution.

@henryhchchc henryhchchc merged commit ce01aaa into henryhchchc:main Oct 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants