Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added marker for codestyle #47

Closed
wants to merge 1 commit into from
Closed

Added marker for codestyle #47

wants to merge 1 commit into from

Conversation

tjcim
Copy link
Contributor

@tjcim tjcim commented Nov 16, 2018

Currently if --strict is used with --codestyle pytest will error stating that there is not a registered marker for codestyle.

This pull requests adds in the marker and includes a test for the changes.

@henry0312
Copy link
Owner

Thank you for your contribution.
I will review after I read some documetns and plugins, because I don't understand makers very well.

@henry0312 henry0312 self-requested a review November 16, 2018 07:48
@henry0312 henry0312 self-assigned this Nov 16, 2018
Copy link
Owner

@henry0312 henry0312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks almost good, but there is a tiny request to improve the explanation of makers.



def pytest_configure(config):
config.addinivalue_line('markers', 'codestyle: Test against pycodestyle')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
config.addinivalue_line('markers', 'codestyle: Test against pycodestyle')
config.addinivalue_line('markers', 'codestyle: mark tests to be checked by pycodestyle.')

@henry0312
Copy link
Owner

ping @tjcim

henry0312 pushed a commit that referenced this pull request Dec 12, 2018
@henry0312 henry0312 closed this Dec 12, 2018
henry0312 added a commit to henry0312/pytest-pydocstyle that referenced this pull request Dec 16, 2018
henry0312 added a commit to henry0312/pytest-pydocstyle that referenced this pull request Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants