Add globbing to codestyle_exclude

[TLATER]

This "works", but it doesn't quite satisfy test cases. Since I'm not
sure what this test case wants to assert, I'm a little stuck here.

[henry0312]

Hello, @TLATER,
I'm sorry for late response.
I don't have much time to review, but I will check #42 and #43 by this weekend.

[henry0312]

This change will fix tests:

diff --git a/test_pytest_codestyle.py b/test_pytest_codestyle.py
--- a/test_pytest_codestyle.py
+++ b/test_pytest_codestyle.py
@@ -46,9 +46,9 @@ def test_ini(testdir):
             ignore = ['d', 'e', 'f']
             assert config.getini('codestyle_ignore') == ignore
             assert config.getini('codestyle_show_source') is True
-            exclude = ['{dirname}/{base}/exclude.py', '{dirname}/{base}/path/to/another/exclude.py']
+            exclude = ['exclude.py', 'path/to/another/exclude.py']
             assert config.getini('codestyle_exclude') == exclude
-    """.format(dirname=testdir.tmpdir.dirname, base=testdir.tmpdir.basename))
+    """)
     p = p.write(p.read() + "\n")
     result = testdir.runpytest('--codestyle')
     result.assert_outcomes(passed=2)

This is because of pathlist of pytest.

[henry0312]

And please update test_pytest_collect_file_with_exclude like this:

diff --git a/test_pytest_codestyle.py b/test_pytest_codestyle.py
--- a/test_pytest_codestyle.py
+++ b/test_pytest_codestyle.py
@@ -65,13 +65,14 @@ def test_pytest_collect_file(testdir):
 def test_pytest_collect_file_with_exclude(testdir):
     testdir.makeini("""
         [pytest]
-        codestyle_exclude = a.py path/to/c.py
+        codestyle_exclude = a.py path/**/?.py
     """)
     testdir.tmpdir.ensure('a.py')
     testdir.tmpdir.ensure('b.py')
     testdir.tmpdir.ensure('path/to/c.py')
+    testdir.tmpdir.ensure('path/to/hoge/foo.py')
     result = testdir.runpytest('--codestyle')
-    result.assert_outcomes(passed=1)
+    result.assert_outcomes(passed=2)


 def test_cache(testdir):

This will add a test case.

[henry0312]

#43 (comment)
#43 (comment)

[TLATER]

Thanks for the review @henry0312 - sorry it took me so long to respond as well ;)

I've simply applied the changes you suggested, is that enough for a merge in your eyes?

[henry0312]

good work!

[lockwooddev]

Will there be a new release for this change?

[henry0312]

I want to release a new version, but I've waited for #47.