-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove seconds for minimumDate
and maximumDate
that affect comparison
#760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yfyau
changed the title
Remove seconds for
Remove seconds for Feb 6, 2024
minimumDate
and maximumDate
that affect comparisonminimumDate
and maximumDate
that affect comparison
henninghall
had a problem deploying
to
e2e Android
February 12, 2024 07:57 — with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e iOS
February 12, 2024 07:57 — with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e Android
February 12, 2024 08:02 — with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e iOS
February 12, 2024 08:02 — with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e Android
February 12, 2024 08:05 — with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e iOS
February 12, 2024 08:05 — with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e Android
February 12, 2024 08:28 — with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e iOS
February 12, 2024 08:28 — with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e Android
February 12, 2024 08:33 — with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e iOS
February 12, 2024 08:33 — with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e iOS
February 12, 2024 08:38 — with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e Android
February 12, 2024 08:38 — with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e Android
February 12, 2024 08:42 — with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e iOS
February 12, 2024 08:42 — with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e Android
February 12, 2024 08:52 — with
GitHub Actions
Error
henninghall
had a problem deploying
to
e2e Android
February 12, 2024 08:53 — with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e iOS
February 12, 2024 09:51 — with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e Android
February 12, 2024 09:52 — with
GitHub Actions
Error
henninghall
had a problem deploying
to
e2e Android
February 12, 2024 09:55 — with
GitHub Actions
Error
henninghall
had a problem deploying
to
e2e Android
February 12, 2024 09:59 — with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e iOS
February 12, 2024 09:59 — with
GitHub Actions
Failure
henninghall
temporarily deployed
to
e2e Android
February 12, 2024 10:00 — with
GitHub Actions
Inactive
henninghall
had a problem deploying
to
e2e Android
February 12, 2024 12:04 — with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e iOS
February 12, 2024 12:04 — with
GitHub Actions
Failure
henninghall
temporarily deployed
to
e2e Android
February 12, 2024 12:07 — with
GitHub Actions
Inactive
Thanks for the PR! Since this is an issue only on android, I moved the code to the android specific component. Also added a test for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves the issue where
onDateChange
is not triggered upon bouncing back to a valid date.Upon reviewing the Android-side code, I identified a date comparison bug. The bug arises because
selectedDate
has its seconds trimmed usinggetFormatPattern()
, whileminimumDate
does not undergo the same process. Consequently, a scenario like01-02-2024 15:30:00 < 01-02-2024 15:30:45
occurs, causing the following condition to always evaluate as false and preventing the code from reaching theEmitter.onDateChange
line.react-native-date-picker/android/src/main/java/com/henninghall/date_picker/ui/WheelChangeListenerImpl.java
Lines 50 to 54 in 1ab9152