Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved spoken feedback #390

Merged

Conversation

mika-lindell
Copy link
Contributor

@mika-lindell mika-lindell commented Sep 14, 2021

  • Improve IosClone spoken feedback when wheel:
    • receives accessibility focus
      • "12th of May, set date, slider, use volume keys to adjust"
      • You can then use volume keys or 2-finger scroll to adjust value
    • when value changes
      • Notify TalkBack about changes through accessibility events instead of explicitly announcing
    • When used with physical keyboard, functions like OS sliders (android.widget.seekBar). For example brightness slider in notification shade.
  • Use accessibility initialisation listener to set contentDescription and other traits
  • Moved accessibility logic only affecting IosClone from wheels to IosClone
  • Refactor Accessibility class to be more tools, less use-case specific methods

Video has sound

screen-20210917-150535_3.mp4

@mika-lindell

This comment has been minimized.

@mika-lindell mika-lindell changed the title Draft: Feature/improved spoken feedback Feature/improved spoken feedback Sep 15, 2021
@mika-lindell mika-lindell changed the title Feature/improved spoken feedback Draft: Feature/improved spoken feedback Sep 15, 2021
@mika-lindell mika-lindell changed the title Draft: Feature/improved spoken feedback Feature/improved spoken feedback Sep 17, 2021
@henninghall henninghall changed the title Feature/improved spoken feedback feat: improved spoken feedback Oct 2, 2021
@henninghall
Copy link
Owner

Great improvements, looks very good to me! Helps a lot to understand the changes when you add that video as well 👍

@henninghall henninghall merged commit e92f779 into henninghall:master Oct 2, 2021
@henninghall
Copy link
Owner

Released this in v4.1.0, I guess some of the boxes can be checked in the roadmap now right? :) #372

@mika-lindell
Copy link
Contributor Author

Thanks for the release, boxes checked ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants