Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Two-finger scroll issue when TalkBack is active #370

Merged

Conversation

mika-lindell
Copy link
Contributor

My best effort on fixing #336

  • Does it by disabling onTouchEvent for all wheels but the one having accessibility focus (IosClone)
  • Shouldn't affect anything when TalkBack isn't active

BEFORE FIX
fail

AFTER FIX
success

@henninghall
Copy link
Owner

Thanks, looks great! What about the nativeAndroid variant, does it already work as intended or does it need a fix too?

@mika-lindell
Copy link
Contributor Author

mika-lindell commented Aug 26, 2021

nativeAndroid variant seems to work for the two finger scrolling part. I noticed it has some issues when reading focused element out loud. For example when values change. Also it might be missing some accessibility labels which would explain context a bit. Some of it could be because our project as well.

@henninghall
Copy link
Owner

Would prefer to have as much of the accessibility-related code in the accessibility class, so I moved it around a bit. Could you confirm it still works as intended? 🙂

@mika-lindell
Copy link
Contributor Author

That looks much better! I might be making some more accessibility-related PRs, so I'll try to follow that example.

Also, the 2-finger TalkBack scroll seems to work as expected.

@henninghall henninghall merged commit 56738d7 into henninghall:master Aug 28, 2021
@henninghall
Copy link
Owner

Thanks, that's appreciated! Release this fix in v3.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants