Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

larger touchable area between wheels #222

Merged
merged 2 commits into from
Jul 31, 2020

Conversation

henninghall
Copy link
Owner

@henninghall henninghall commented Jul 28, 2020

Fixes #145

@henninghall henninghall changed the title bigger touchable area - even between wheels larger touchable area between wheels Jul 28, 2020
@henninghall henninghall marked this pull request as ready for review July 31, 2020 09:59
@henninghall henninghall merged commit 37c1338 into master Jul 31, 2020
@mars-lan
Copy link
Contributor

mars-lan commented Aug 8, 2020

While not 100% sure, it seems that this PR may have broken the ability to set the width of the picker on Android (for iOS clone), e.g. the following code used to work on 3.0.3 but had no effect on 3.1.0

<DatePicker style={{width: WIDTH}} />

@mars-lan
Copy link
Contributor

@henninghall ^^^

@ttristan
Copy link

@mars-lan could you come up with a workaround for the time being? I tried setting `width: Dimensions.get('screen').width' which applies to the component width but not the Picker itself.

@mars-lan
Copy link
Contributor

@ttristan my workaround is to simply stick to 3.0.3 for now :)

@henninghall
Copy link
Owner Author

@ttristan @mars-lan This should be fixed in v3.2.1 🙂

@mars-lan
Copy link
Contributor

@henninghall it's fixed indeed. Thanks for the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrollable white spaces between wheels
3 participants