Upgrades storybook to v5 #591
Conversation
Pull Request Test Coverage Report for Build 2046
💛 - Coveralls |
|
Deploy preview for hsds-react ready! Built with commit ab8e673 |
|
So excited for this!!!!! |
package.json
Outdated
| @@ -20,7 +20,8 @@ | |||
| "Lauren Brown", | |||
| "Pierre-Luc Babin", | |||
| "Buzz Usborne <[email protected]>", | |||
| "Alisdair McDiarmid" | |||
| "Alisdair McDiarmid", | |||
| "Juan Pablo Lomeli Diaz <[email protected]>" | |||
| @@ -163,6 +164,7 @@ | |||
| "css-loader": "0.28.4", | |||
| "cypress": "^3.1.5", | |||
| "dotenv": "4.0.0", | |||
| "emotion-theming": "^10.0.10", | |||
There was a problem hiding this comment.
Wow. I'm surprised an Emotion 10 package didn't blow up Fancy! (which is on Emotion 9)
There was a problem hiding this comment.
I was worried about that too and for a moment thought it could be a blocker... but seems fine 🤞
|
@tinkertrain I made a tiny update. I added @TerrenceLJones to |
There was a problem hiding this comment.
🚀 from me! Builds locally, and seems to build correctly on Netlify!
Stories work as expected!!
@tinkertrain Thank you so much!!!!
|
Hmm.. wait a sec. Netlify failed now. But why |
|
Lemme try rebuilding package-lock.json? |
|
Hmm. Nope. Pushing my |
might be an issue with netlify. #594 is failing as well |
|
@plbabin Maybe... both of those PRs were done by @tinkertrain though. I'm weeding out the chance that.. somehow.. Juan Pablo's machine did something to We experienced something like that in the application |
|
Wut Netlify. Come on! |
…t/hsds-react into enhancement/upgrade-storybook-5
|
@knicklabs An Artboard feature I really like is the ability to drag/resize the canvas. Handy for responsive testing and for things like Dropdown :). I think perhaps I can slim down and adjust Artboard for Storybook 5 use. That way, the features compliment vs. clash |
Upgrades storybook to v5
Storybook v5 has a bunch of nice things added, among them a much nicer UI and a few extra things. More info here
Followed the instructions found here:
Upgrading notes
Upgrade went relatively smooth, I did find a couple of issues with dependencies. Below are some related issues I found and by following some suggestions inside the conversations there, I managed to get v5 running without further issues:
Fixes outside the migration guide:
emotion-theming@10to devDependencies@storybook/theming@latestto devDependencies (in theory it is included as a dependency in the storybook package, but I found that it has to be added)