add digitize/bucketize #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #928 +/- ##
==========================================
- Coverage 95.47% 95.47% -0.01%
==========================================
Files 64 64
Lines 9877 9898 +21
==========================================
+ Hits 9430 9450 +20
- Misses 447 448 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…z-analytics/heat into features/926-digitize-bucketize
mtar
commented
Mar 28, 2022
mtar
commented
Mar 28, 2022
CodeSee Review Map:Review in an interactive map View more CodeSee Maps Legend |
There was a problem hiding this comment.
@mtar thanks for this. I'm ready to approve it, maybe mention in the documentation that bins and boundaries cannot be distributed?
mtar
commented
Apr 8, 2022
heat/core/statistics.py
Outdated
| x : DNDarray | ||
| The input array | ||
| bins : DNDarray or torch.Tensor | ||
| A 1-dimensional array containing a monotonic sequence describing the bin boundaries. |
There was a problem hiding this comment.
cannot be distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implementation of digitize and bucketize
Issue/s resolved: #926
Changes proposed:
Type of change
-New Feature
Memory requirements
Performance
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no