Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add swapaxes #853

Merged
merged 6 commits into from
Aug 20, 2021
Merged

add swapaxes #853

merged 6 commits into from
Aug 20, 2021

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Jul 30, 2021

Description

Adds swapaxes. It is mostly an alias function for transpose on two axes.

Issue/s resolved: #849

Changes proposed:

  • add swapaxes

Type of change

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #853 (9b12c64) into master (e7c13c6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #853   +/-   ##
=======================================
  Coverage   95.36%   95.37%           
=======================================
  Files          64       64           
  Lines        9153     9162    +9     
=======================================
+ Hits         8729     8738    +9     
  Misses        424      424           
Flag Coverage Δ
gpu 94.52% <100.00%> (+<0.01%) ⬆️
unit 91.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/core/manipulations.py 99.07% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7c13c6...9b12c64. Read the comment docs.

Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @mtar! Just a couple small things (removal of instance checks and implementation of method)

heat/core/manipulations.py Outdated Show resolved Hide resolved
heat/core/manipulations.py Outdated Show resolved Hide resolved
heat/core/manipulations.py Show resolved Hide resolved
heat/core/tests/test_manipulations.py Outdated Show resolved Hide resolved
@ClaudiaComito ClaudiaComito added this to the 1.2.x milestone Aug 18, 2021
coquelin77
coquelin77 previously approved these changes Aug 20, 2021
Copy link
Member

@coquelin77 coquelin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as #854 looks good with changes already addressed. merging

@coquelin77 coquelin77 merged commit 634a2bd into master Aug 20, 2021
@coquelin77 coquelin77 deleted the feature/849-swapaxes branch August 20, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement swapaxes
3 participants