Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/795-reshape split none to new split #796

Merged
merged 24 commits into from
Jun 24, 2021

Conversation

ClaudiaComito
Copy link
Contributor

@ClaudiaComito ClaudiaComito commented Jun 14, 2021

Description

Issue/s resolved: #795

Changes proposed:

  • reshape(a, shape, new_split) now returns a distributed DNDarray if new_split is not None even if a is not distributed
  • update keyword argument for reshape() method to new_split from old axis
  • allow shape elements to be passed in as separate arguments when calling the reshape() method
  • replace unnecessary factories.array() calls with DNDarray() for a significant improvement in performance
  • update tests

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #796 (aa16095) into master (8e7b14d) will increase coverage by 0.01%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #796      +/-   ##
==========================================
+ Coverage   95.28%   95.29%   +0.01%     
==========================================
  Files          64       64              
  Lines        8964     8972       +8     
==========================================
+ Hits         8541     8550       +9     
+ Misses        423      422       -1     
Flag Coverage Δ
gpu 94.42% <92.85%> (+0.01%) ⬆️
unit 90.87% <92.85%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/core/manipulations.py 99.07% <92.85%> (-0.18%) ⬇️
heat/core/dndarray.py 97.25% <0.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e7b14d...aa16095. Read the comment docs.

@ClaudiaComito ClaudiaComito requested review from mtar, coquelin77, lenablind and ben-bou and removed request for mtar June 14, 2021 15:23
@ClaudiaComito ClaudiaComito added API Anything relating the API bug Something isn't working enhancement New feature or request labels Jun 14, 2021
ben-bou
ben-bou previously approved these changes Jun 17, 2021
@ben-bou ben-bou mentioned this pull request Jun 22, 2021
4 tasks
@ClaudiaComito ClaudiaComito added this to the 1.1.x milestone Jun 23, 2021
@coquelin77 coquelin77 merged commit f7f6c35 into master Jun 24, 2021
@mtar mtar deleted the bug/reshape-splitNone-to-new_split branch February 28, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Anything relating the API bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reshape issues: no split to new_split, method vs. function call, input *shape not supported
3 participants