Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix split semantics for reduction operations #744

Merged
merged 11 commits into from
Mar 24, 2021

Conversation

ClaudiaComito
Copy link
Contributor

@ClaudiaComito ClaudiaComito commented Mar 16, 2021

Description

Fixing split semantics for reduction operations (see Issue #730 )

Together with #732 , solves #730

Changes proposed:

  • adjust split axis when DNDarray dimensions change following a reduction operation.
  • update tests

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #744 (24878fc) into master (99aec49) will increase coverage by 1.62%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #744      +/-   ##
==========================================
+ Coverage   94.21%   95.83%   +1.62%     
==========================================
  Files          63       63              
  Lines        8090     8096       +6     
==========================================
+ Hits         7622     7759     +137     
+ Misses        468      337     -131     
Flag Coverage Δ
gpu 94.95% <100.00%> (?)
unit 94.21% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/core/_operations.py 96.82% <100.00%> (+0.08%) ⬆️
heat/core/dndarray.py 96.49% <0.00%> (+0.12%) ⬆️
heat/core/statistics.py 98.00% <0.00%> (+0.72%) ⬆️
heat/core/factories.py 100.00% <0.00%> (+0.85%) ⬆️
heat/core/linalg/basics.py 92.09% <0.00%> (+1.93%) ⬆️
heat/utils/data/partial_dataset.py 94.38% <0.00%> (+2.08%) ⬆️
heat/core/tests/test_suites/basic_test.py 96.11% <0.00%> (+4.85%) ⬆️
heat/core/communication.py 96.67% <0.00%> (+6.45%) ⬆️
heat/core/devices.py 97.67% <0.00%> (+11.62%) ⬆️
heat/nn/functional.py 100.00% <0.00%> (+40.00%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99aec49...24878fc. Read the comment docs.

@ClaudiaComito ClaudiaComito added the bug Something isn't working label Mar 16, 2021
@ClaudiaComito
Copy link
Contributor Author

I branched off the main branch by mistake instead of off 0.5.x.

@coquelin77 coquelin77 merged commit 342cd5f into master Mar 24, 2021
@coquelin77 coquelin77 deleted the bug/730-reduce_op_split_axis branch March 24, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong split axis after summing along axis or indexing
2 participants