Feature/737 isreal iscomplex #738
Conversation
Codecov Report
@@ Coverage Diff @@
## master #738 +/- ##
=======================================
Coverage 95.98% 95.98%
=======================================
Files 63 63
Lines 8060 8069 +9
=======================================
+ Hits 7736 7745 +9
Misses 324 324
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| sanitation.sanitize_in(x) | ||
|
|
||
| if issubclass(x.dtype, _complexfloating): | ||
| return x.imag != 0 | ||
| else: | ||
| return factories.zeros(x.shape, bool, split=x.split, device=x.device, comm=x.comm) |
There was a problem hiding this comment.
why not use torch.is_complex?
There was a problem hiding this comment.
I did not find it 🔍 😄
There was a problem hiding this comment.
torch.is_complex returns the result for the whole tensor, not element-wise
There was a problem hiding this comment.
wow. that is a really annoying difference. but that is what it is
| sanitation.sanitize_in(x) | ||
|
|
||
| if issubclass(x.dtype, _complexfloating): | ||
| return x.imag != 0 | ||
| else: | ||
| return factories.zeros(x.shape, bool, split=x.split, device=x.device, comm=x.comm) |
There was a problem hiding this comment.
wow. that is a really annoying difference. but that is what it is
Description
Add iscomplex() and isreal() functionality that checks element-wise for complex or real values.
Issue/s resolved: #737
Changes proposed:
Type of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no