Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix local_op + out distributed #734

Merged
merged 4 commits into from
Mar 16, 2021
Merged

fix local_op + out distributed #734

merged 4 commits into from
Mar 16, 2021

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Mar 10, 2021

Description

Fix distributed local_op with out != None for empty local arrays.

Issue resolved: #731

Changes proposed:

  • set multiples to zero if division by zero occurs

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@mtar mtar added the bug Something isn't working label Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #734 (12e32ac) into master (ebaf73c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #734   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files          63       63           
  Lines        8056     8056           
=======================================
  Hits         7719     7719           
  Misses        337      337           
Flag Coverage Δ
gpu 94.92% <100.00%> (ø)
unit 94.18% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/core/_operations.py 96.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebaf73c...12e32ac. Read the comment docs.

@mtar mtar marked this pull request as ready for review March 10, 2021 08:59
@coquelin77 coquelin77 merged commit 2f69e2e into master Mar 16, 2021
@coquelin77 coquelin77 deleted the bug/731-local_op-out branch March 16, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__local_op with out parameter
2 participants