Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement isfinite isinf isnan #711

Merged
merged 7 commits into from
Feb 11, 2021
Merged

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Jan 6, 2021

Description

Issue/s resolved: #710

Changes proposed:

  • new features: isfinite, isinf, isnan

Type of change

  • New feature (non-breaking change which adds functionality)

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@mtar mtar added enhancement New feature or request local operator labels Jan 6, 2021
@mtar mtar requested review from Cdebus and ClaudiaComito January 6, 2021 14:51
coquelin77
coquelin77 previously approved these changes Jan 11, 2021
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #711 (7987449) into master (379aae9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #711   +/-   ##
=======================================
  Coverage   94.40%   94.40%           
=======================================
  Files          51       51           
  Lines        7447     7453    +6     
=======================================
+ Hits         7030     7036    +6     
  Misses        417      417           
Flag Coverage Δ
unit 94.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/core/logical.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 379aae9...7987449. Read the comment docs.

@mtar mtar marked this pull request as draft February 2, 2021 12:03
@mtar mtar force-pushed the Feature/710-isfinite_isinf_isnan branch from 89579e4 to efa5770 Compare February 2, 2021 12:58
@mtar mtar marked this pull request as ready for review February 2, 2021 13:33
coquelin77
coquelin77 previously approved these changes Feb 11, 2021
@coquelin77 coquelin77 merged commit 717e168 into master Feb 11, 2021
@coquelin77 coquelin77 deleted the Feature/710-isfinite_isinf_isnan branch February 11, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request local operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement isinf, isfinite, isnan functions
2 participants