-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
685 ravel function + 696 reshape infer dimension #690
Conversation
Codecov Report
@@ Coverage Diff @@
## master #690 +/- ##
==========================================
+ Coverage 95.82% 96.00% +0.18%
==========================================
Files 63 63
Lines 8071 8091 +20
==========================================
+ Hits 7734 7768 +34
+ Misses 337 323 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…at into feature/685-ravel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mtar, looks good! I only have some minor requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only a doc comment (missed function link) everything else looks good
All comments have been addressed
Description
This PR adds a ravel functionality to heat. It works mostly the same as flatten, but it uses shallow copies / views for the data when split=0.
Issue/s resolved: #685
Reshape infers the shape if one unknown dimension -1 is specified.
Issue/s resolved: #696
Changes proposed:
Type of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no