Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove MPIRequest.wait() #672

Merged
merged 5 commits into from
Sep 22, 2020
Merged

remove MPIRequest.wait() #672

merged 5 commits into from
Sep 22, 2020

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Sep 14, 2020

Description

Removes the wait method of MPIRequest such that it does not interfere with the lowercase non-blocking MPI functions of mpi4py.

Issue/s resolved: #671

Changes proposed:

  • delete MPIRequest.wait()
  • fix calls using wait() to Wait()

Type of change

  • Bug fix
  • Breaking change

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #672 into master will increase coverage by 0.01%.
The diff coverage is 98.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
+ Coverage   97.44%   97.46%   +0.01%     
==========================================
  Files          87       87              
  Lines       17099    17093       -6     
==========================================
- Hits        16662    16659       -3     
+ Misses        437      434       -3     
Impacted Files Coverage Δ
heat/core/communication.py 90.35% <ø> (+0.47%) ⬆️
heat/core/linalg/qr.py 99.28% <75.00%> (ø)
heat/core/arithmetics.py 99.29% <100.00%> (ø)
heat/core/dndarray.py 96.71% <100.00%> (ø)
heat/core/linalg/basics.py 94.46% <100.00%> (ø)
heat/core/manipulations.py 99.22% <100.00%> (ø)
heat/core/tests/test_communication.py 97.96% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2e6b2d...1eb20de. Read the comment docs.

@mtar mtar force-pushed the enhancement/671-wait branch from 7e83d67 to b0d4ba5 Compare September 15, 2020 11:52
@mtar mtar force-pushed the enhancement/671-wait branch from b0d4ba5 to 136a053 Compare September 15, 2020 12:13
@mtar mtar changed the title remove MPIRequest.wait() and some calls remove MPIRequest.wait() Sep 16, 2020
@mtar mtar marked this pull request as ready for review September 16, 2020 07:23
@mtar mtar requested review from Markus-Goetz and coquelin77 and removed request for Markus-Goetz and coquelin77 September 16, 2020 07:25
@mtar
Copy link
Collaborator Author

mtar commented Sep 22, 2020

rerun tests

@coquelin77
Copy link
Member

why do we need to remove wait? what was it interfering with? isnt it something that we should have?

@coquelin77 coquelin77 merged commit 587db9b into master Sep 22, 2020
@coquelin77 coquelin77 deleted the enhancement/671-wait branch September 22, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

communication MPIRequest.wait()
2 participants