Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement reshape rename axis to new_split and add description #667

Merged
merged 2 commits into from
Sep 7, 2020

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Sep 7, 2020

Description

Renaming of the axis parameter and additional hint that it only works on split DNDarrays.

Issue/s resolved: #665

Changes proposed:

  • rename axis to new_split
  • add further description

Type of change

  • Documentation update

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@mtar mtar requested review from coquelin77 and lenablind September 7, 2020 13:35
@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #667 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #667   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files          85       85           
  Lines       16646    16646           
=======================================
  Hits        16209    16209           
  Misses        437      437           
Impacted Files Coverage Δ
heat/core/manipulations.py 99.12% <100.00%> (ø)
heat/core/tests/test_manipulations.py 99.91% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2ca002...667503a. Read the comment docs.

Copy link
Collaborator

@lenablind lenablind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adapting the function so quickly!

@coquelin77 coquelin77 merged commit 6f83026 into master Sep 7, 2020
@coquelin77 coquelin77 deleted the Enhancement/665-reshape_parameter branch September 7, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

axis parameter of reshape does not change split axis
3 participants