add random_sample and aliases #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #664 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 85 85
Lines 16646 16676 +30
=======================================
+ Hits 16209 16239 +30
Misses 437 437
Continue to review full report at Codecov.
|
coquelin77
requested changes
Sep 7, 2020
heat/core/random.py
Outdated
|
|
||
|
|
||
| # aliases | ||
| random_sample = ranf = sample = random |
There was a problem hiding this comment.
where is randf from? i cant find that name in other packages
There was a problem hiding this comment.
I found ranf as an alias in numpy.
coquelin77
previously approved these changes
Sep 7, 2020
coquelin77
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adding random functions and aliases
Issue/s resolved: #553
Changes proposed:
Type of change
New Feature
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no