Features/584 data parallel #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltz-analytics/heat into features/584-DataParallel
…ltz-analytics/heat into features/584-DataParallel
…ltz-analytics/heat into features/584-DataParallel
…er to reversed computation order
…ltz-analytics/heat into features/584-DataParallel
|
This branch is updated and the tests run clean. there is no way to increase the coverage for this branch without overhauling how coverage is reported. It is also important to note that since this development, there have been many improvements to the data parallel neural networks which builds on these addition. If there are questions / comments for this PR I will give it until the end of the year, then it will be merged into the master. I apologize for the length of this PR as well. The length was unavoidable for this feature |
…ltz-analytics/heat into features/584-DataParallel Conflicts: heat/nn/__init__.py heat/nn/tests/test_data_parallel.py heat/optim/__init__.py
|
rerun tests |
1 similar comment
|
rerun tests |
|
this is going to be forced in. Other changes are waiting and can be made on the fly |
This was referenced Mar 2, 2021
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of Data Parallel Neural Networks. Documentation about how to use in still being written. This is still not a final iteration, there are many things which will be tuned in the background.
Issue/s resolved: #584 #585 #603 #604 #605 #606
Changes proposed:
DataParallelclassDataLoaderclassDatasetclass (template)torch.nnmodules andtorch.nn.functionalroutinesMNISTDatasetadded for loading data and preparing for the network architectureType of change
Due Diligence
All split configurations testedDoes this change modify the behaviour of other functions? If so, which?
no
Notes
There will be backend changes for efficiency coming in the future. however, this feature is becoming rather large and a review/merge would make it more manageable in the future