Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarking scripts for paper and continuous benchmarking #652

Merged
merged 5 commits into from
Aug 18, 2020

Conversation

Markus-Goetz
Copy link
Member

Implemented and unified benchmarks for the paper. First step towards continuous benchmarking by providing benchmark configurations, jobscript generation and optional batch submission. Actual implementation in line with PRs/releases still missing.

Description

Issue partially resolved: #466

Changes proposed:

  • Added statistical moments benchmark
  • Added distance matrix benchmark
  • Added kmeans benchmark
  • Added lasso benchmark
  • Added configuration files for each benchmark
  • Added jobscript generator with optional submission to batch system

Type of change

  • New feature (non-breaking change which adds functionality)

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

…ks. Added notion of benchmark configuration as JSON file. Added jobscript generator for generating and optionally submitting benchmark jobs from the configuration files
@mtar
Copy link
Collaborator

mtar commented Aug 7, 2020

Can one of the admins verify this patch?

Copy link
Member

@coquelin77 coquelin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to either have everything as floats or as doubles in np and dask, as well as in heat

need 2 processes for CPUs

perf counters not started everywhere. are we using these? it doesnt work for dask anyway

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #652 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #652   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files          85       85           
  Lines       16646    16646           
=======================================
  Hits        16209    16209           
  Misses        437      437           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82c0df5...76342e8. Read the comment docs.

Copy link
Contributor

@Cdebus Cdebus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some things still not entirely correct

@coquelin77 coquelin77 merged commit 11bc781 into master Aug 18, 2020
@coquelin77 coquelin77 deleted the features/466-continuous-benchmarking branch August 18, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continuous Benchmarking
4 participants