-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmarking scripts for paper and continuous benchmarking #652
Conversation
…ks. Added notion of benchmark configuration as JSON file. Added jobscript generator for generating and optionally submitting benchmark jobs from the configuration files
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to either have everything as floats or as doubles in np and dask, as well as in heat
need 2 processes for CPUs
perf counters not started everywhere. are we using these? it doesnt work for dask anyway
Codecov Report
@@ Coverage Diff @@
## master #652 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 85 85
Lines 16646 16646
=======================================
Hits 16209 16209
Misses 437 437 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some things still not entirely correct
Implemented and unified benchmarks for the paper. First step towards continuous benchmarking by providing benchmark configurations, jobscript generation and optional batch submission. Actual implementation in line with PRs/releases still missing.
Description
Issue partially resolved: #466
Changes proposed:
Type of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no