Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced NotImplemented with NotImplementedError #651

Merged
merged 4 commits into from
Aug 14, 2020
Merged

Replaced NotImplemented with NotImplementedError #651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68f8eef
Replaced NotImplemented with NotImplementedError
Inzlinger Aug 6, 2020
ec4221d
Changelog
Inzlinger Aug 6, 2020
77157b3
Update CHANGELOG.md
coquelin77 Aug 10, 2020
de1e248
Merge branch 'master' into bug/650-NotImplementedError
coquelin77 Aug 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
- [#638](https://github.com/helmholtz-analytics/heat/pull/638) Fix: arange returns float32 with single input of type float & update skipped device tests
- [#639](https://github.com/helmholtz-analytics/heat/pull/639) Bugfix: balanced array in demo_knn, changed behaviour of knn
- [#648](https://github.com/helmholtz-analytics/heat/pull/648) Bugfix: tensor printing with PyTorch 1.6.0
- [#651](https://github.com/helmholtz-analytics/heat/pull/651) Bugfix: `NotImplemented` is now `NotImplmentedError` in `core.communication.Communication` base class
- [#653](https://github.com/helmholtz-analytics/heat/pull/653) Printing above threshold gathers the data without a buffer now
- [#653](https://github.com/helmholtz-analytics/heat/pull/653) Bugfixes: Update unittests argmax & argmin + force index order in mpi_argmax & mpi_argmin. Add device parameter for tensor creation in dndarray.get_halo().

Expand Down
6 changes: 3 additions & 3 deletions heat/core/communication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@
class Communication:
@staticmethod
def is_distributed():
return NotImplemented
raise NotImplementedError()

def __init__(self):
return NotImplemented
raise NotImplementedError()

def chunk(self, shape, split):
"""
Expand All @@ -47,7 +47,7 @@ def chunk(self, shape, split):
slices : tuple of slices
the chunk slices with respect to the given shape
"""
return NotImplemented
raise NotImplementedError()


class MPICommunication(Communication):
Expand Down