Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added resplit to None for slicing with DNDarrays #635

Merged
merged 2 commits into from
Jul 20, 2020

Conversation

coquelin77
Copy link
Member

@coquelin77 coquelin77 commented Jul 20, 2020

Description

Update to slicing with DNDarrays

Issue/s resolved: n/a

Changes proposed:

  • resplit to split None if the key given to the DNDarray getitem is itself a DNDarray

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

yes, possibly. If a function was working with unbalanced DNDarrays then this slicing scheme would cause issues

@coquelin77 coquelin77 requested a review from Markus-Goetz July 20, 2020 08:55
@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #635 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #635   +/-   ##
=======================================
  Coverage   97.52%   97.52%           
=======================================
  Files          77       77           
  Lines       16102    16105    +3     
=======================================
+ Hits        15704    15707    +3     
  Misses        398      398           
Impacted Files Coverage Δ
heat/core/dndarray.py 97.22% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d7c95c...87b7da7. Read the comment docs.

@Markus-Goetz Markus-Goetz merged commit c6bf24d into master Jul 20, 2020
@Markus-Goetz Markus-Goetz deleted the bug/assorted_bug_fixes_0 branch July 20, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants