-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/556 assign label #620
Conversation
…at into features/556-assign_label
…tures/556-assign_label
…at into features/556-assign_label
…tures/556-assign_label
Codecov Report
@@ Coverage Diff @@
## master #620 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 77 77
Lines 15869 15869
=======================================
Hits 15472 15472
Misses 397 397 Continue to review full report at Codecov.
|
|
||
Parameters | ||
---------- | ||
x : ht.DNDarray |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the required
.
Please check the capitalization of words (start of sentence, nouns lower case).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The required are still in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny thin still
Bump, please remove the required comments from the docstrings and add this PR to the Changelog |
Description
Implements the K-Nearest-Niehgbour Algorithm.
Maybe wait with merge until #601 is fixed.
Type of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no