Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/556 assign label #620

Merged
merged 14 commits into from
Jul 10, 2020
Merged

Features/556 assign label #620

merged 14 commits into from
Jul 10, 2020

Conversation

Inzlinger
Copy link
Collaborator

Description

Implements the K-Nearest-Niehgbour Algorithm.
Maybe wait with merge until #601 is fixed.

Type of change

  • New feature (non-breaking change which adds functionality)

Due Diligence

  • [ x] All split configurations tested
  • [ x] Multiple dtypes tested in relevant functions
  • [ x] Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@Inzlinger Inzlinger requested a review from Markus-Goetz July 6, 2020 08:34
@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #620 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #620   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files          77       77           
  Lines       15869    15869           
=======================================
  Hits        15472    15472           
  Misses        397      397           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67308b4...3685c3d. Read the comment docs.

heat/classification/knn.py Show resolved Hide resolved
heat/classification/knn.py Show resolved Hide resolved
heat/classification/knn.py Show resolved Hide resolved
heat/classification/knn.py Show resolved Hide resolved
heat/classification/knn.py Show resolved Hide resolved

Parameters
----------
x : ht.DNDarray
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the required.

Please check the capitalization of words (start of sentence, nouns lower case).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The required are still in

examples/classification/demo_knn.py Show resolved Hide resolved
examples/classification/demo_knn.py Show resolved Hide resolved
examples/classification/demo_knn.py Show resolved Hide resolved
examples/classification/demo_knn.py Outdated Show resolved Hide resolved
Copy link
Member

@Markus-Goetz Markus-Goetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny thin still

@Markus-Goetz
Copy link
Member

Bump, please remove the required comments from the docstrings and add this PR to the Changelog

@Markus-Goetz Markus-Goetz merged commit c17b405 into master Jul 10, 2020
@Markus-Goetz Markus-Goetz deleted the features/556-assign_label branch July 10, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants