Features/173 stack #608
Merged
Features/173 stack #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #608 +/- ##
==========================================
+ Coverage 97.49% 97.52% +0.02%
==========================================
Files 77 77
Lines 15877 16102 +225
==========================================
+ Hits 15480 15704 +224
- Misses 397 398 +1
Continue to review full report at Codecov.
|
coquelin77
requested changes
Jul 1, 2020
|
bump, merge conflicts |
Cdebus
requested changes
Jul 14, 2020
heat/core/manipulations.py
Outdated
|
|
||
| The ``axis`` parameter specifies the index of the new axis in the dimensions of the result. | ||
| For example, if ``axis=0``, the arrays will be stacked along the first dimension; if ``axis=-1``, | ||
| they will be stacked along the last dimension. |
There was a problem hiding this comment.
Maybe include the note on the split that you mention above in the PR description. That is very useful to know i believe
There was a problem hiding this comment.
You're absolutely right. I've added a Notes section about split semantics and references to it in the text.
Cdebus
previously approved these changes
Jul 14, 2020
coquelin77
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of
ht.stack(),ht.column_stack(), andht.row_stack().ht.stack(arrays, axis)joins a sequence of DNDarrays along a newly created dimension, specified by the argumentaxis. It usestorch.stack()under the hood. Even in the distributed case, no communication is required, since the stacking by definition happens along a new axis, and the conditionsplit == axisis therefore never verified.Distribution of output:
stack()requires that all arrays in the sequence be split along the same dimension. After stacking, the data are still distributed in the original dimension, however a new dimension has been added, so the original dimension might now besplit+1:axis <= split, output is distributed alongsplit+1axis > split, output is distributed alongsplitht.column_stack(arrays)andht.row_stack(arrays)stack 1-D or 2-D DNDarrays as columns or rows, respectively, into 2-D DNDarrays. In practice, they stack, if all arrays are 1-D, or concatenate, if at least one of the arrays is 2-D.Issue/s resolved: #173, #544
Changes proposed:
Type of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no