Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for matmul bug (split 10) #573

Merged
merged 2 commits into from
May 25, 2020
Merged

Conversation

coquelin77
Copy link
Member

Matmul had a bug for when kB (the inner blocking dimension is 1, when this was the case, it would do a second loop which would re-add previous results to the result array.

Description

matmul of 2 vectors is handled as an early out
in split 10 case for matmul, the remainder handling does not run if kB is equal to 0

Issue/s resolved: #570

Changes proposed:

  • see description

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

…or 10 case

cg: minor formating change (1 line break)
@coquelin77 coquelin77 requested review from Cdebus and d1saster May 25, 2020 11:27
@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #573 into master will increase coverage by 0.00%.
The diff coverage is 39.28%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #573   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files          75       75           
  Lines       15143    15145    +2     
=======================================
+ Hits        14608    14610    +2     
  Misses        535      535           
Impacted Files Coverage Δ
heat/core/linalg/solver.py 68.36% <ø> (ø)
heat/core/linalg/basics.py 93.67% <39.28%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73f281c...f0b6a56. Read the comment docs.

@coquelin77
Copy link
Member Author

codecov patch is failing but i cannot see why. however, the full coverage is hopefully fine.

Copy link
Member

@d1saster d1saster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thx for fixing the issue :)

@coquelin77 coquelin77 merged commit 042d0a8 into master May 25, 2020
@coquelin77 coquelin77 deleted the bug/570-possible-mm-or-cg branch May 25, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible bug or undefined behavior in CG or matmul?
2 participants