Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug distributed scalar #507

Merged
merged 6 commits into from
Apr 3, 2020
Merged

bug distributed scalar #507

merged 6 commits into from
Apr 3, 2020

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Mar 16, 2020

Description

Include a summary of the change/s.
Please also include relevant motivation and context. List any dependencies that are required for this change.

This PR fixes the error creating a scalar with split axis != None. The axis will be set to None implicitly.

Issue/s resolved: #492

Changes proposed:

  • In sanitize axis change axis to None if len(shape) == 0

Type of change

Remove irrelevant options:

  • Bug fix (non-breaking change which fixes an issue)

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

yes / no

@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #507 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #507   +/-   ##
=======================================
  Coverage   96.60%   96.60%           
=======================================
  Files          68       68           
  Lines       14091    14094    +3     
=======================================
+ Hits        13612    13615    +3     
  Misses        479      479           
Impacted Files Coverage Δ
heat/core/stride_tricks.py 100.00% <100.00%> (ø)
heat/core/tests/test_stride_tricks.py 91.52% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d4be7...99233e9. Read the comment docs.

@mtar mtar changed the title bug split scalar bug distributed scalar Apr 2, 2020
CHANGELOG.md Show resolved Hide resolved
@Markus-Goetz Markus-Goetz self-requested a review April 3, 2020 12:58
Markus-Goetz
Markus-Goetz previously approved these changes Apr 3, 2020
@Markus-Goetz Markus-Goetz self-requested a review April 3, 2020 13:16
@Markus-Goetz Markus-Goetz merged commit 95fda46 into master Apr 3, 2020
@Markus-Goetz Markus-Goetz deleted the Bug/492-scalar_split branch April 3, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug distributed array from scalar
3 participants