Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api/remove ml #431

Merged
merged 10 commits into from
Dec 12, 2019
Merged

Api/remove ml #431

merged 10 commits into from
Dec 12, 2019

Conversation

ClaudiaComito
Copy link
Contributor

@ClaudiaComito ClaudiaComito commented Dec 10, 2019

Description

Removing the ml sub-module, cluster and regression are now directly below the ht module namespace. Also, provided __init__.py file to lasso/tests which had gone untested and unnoticed so far.

Fixes: #398

Changes proposed:

Type of change

Select relevant options.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Are all split configurations tested and accounted for?
[x] yes [ ] no
Does this change require a documentation update outside of the changes proposed?
[x] yes [ ] no
Does this change modify the behaviour of other functions?
[ ] yes [x] no
Are there code practices which require justification?
[ ] yes [x] no

@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #431 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
- Coverage   96.57%   96.57%   -0.01%     
==========================================
  Files          55       54       -1     
  Lines       11951    11950       -1     
==========================================
- Hits        11542    11541       -1     
  Misses        409      409
Impacted Files Coverage Δ
heat/core/regression/lasso/lasso.py 90.19% <ø> (ø)
heat/core/cluster/kmeans.py 81.15% <ø> (ø)
heat/core/regression/__init__.py 100% <ø> (ø)
heat/core/cluster/__init__.py 100% <ø> (ø)
heat/core/regression/lasso/__init__.py 100% <ø> (ø)
heat/core/cluster/tests/test_kmeans.py 80% <100%> (ø)
heat/core/regression/lasso/tests/test_lasso.py 94.11% <100%> (ø)
heat/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45b8640...408cbf6. Read the comment docs.

coquelin77
coquelin77 previously approved these changes Dec 12, 2019
@coquelin77 coquelin77 merged commit 7c913f0 into master Dec 12, 2019
@coquelin77 coquelin77 deleted the API/remove_ml branch December 12, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the ml sub-module
2 participants