Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement __radd__ #295

Conversation

krajsek
Copy link
Member

@krajsek krajsek commented Jun 3, 2019

solves issue #168

@krajsek krajsek requested review from Markus-Goetz and Cdebus June 3, 2019 21:36
@codecov-io
Copy link

Codecov Report

Merging #295 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
+ Coverage   96.28%   96.29%   +<.01%     
==========================================
  Files          47       47              
  Lines        6731     6742      +11     
==========================================
+ Hits         6481     6492      +11     
  Misses        250      250
Impacted Files Coverage Δ
heat/core/tests/test_arithmetics.py 100% <100%> (ø) ⬆️
heat/core/dndarray.py 89.07% <100%> (+0.06%) ⬆️
heat/core/arithmetics.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b345f16...082f945. Read the comment docs.

Copy link
Member

@Markus-Goetz Markus-Goetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@Markus-Goetz
Copy link
Member

Might be inside the master now, due to the merge of the generic right-hand side operator branch.

@krajsek krajsek closed this Jun 4, 2019
@Markus-Goetz Markus-Goetz deleted the features/168-provide-implementation-of-right-hand-side-binary-operations branch April 7, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants