167 tensor redistribution for binary operations #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Scalars are not converted to 1D tensors, but are passed directly to torch opperation - Error handling for non-supported types is passed on from torch
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
==========================================
+ Coverage 96.17% 96.26% +0.08%
==========================================
Files 47 47
Lines 6514 6643 +129
==========================================
+ Hits 6265 6395 +130
+ Misses 249 248 -1
Continue to review full report at Codecov.
|
|
Bump, still needs improvement with respect to broadcasting |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #167
Option for two different split axes not implemented yet, as it first needs fixing of #233 for allgather.
However, should still be merged, since it fixes issues regarding one split and one non-split tensor.
Also, better handling of cases with scalar values is supported