Bug fix: printing non-distributed data #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1756 +/- ##
=======================================
Coverage 92.26% 92.26%
=======================================
Files 84 84
Lines 12445 12447 +2
=======================================
+ Hits 11482 11484 +2
Misses 963 963
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thank you for the PR! |
mrfh92
approved these changes
Jan 20, 2025
|
Thank you for the PR! |
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
* make 1-proc print great again * fix tabs size * skip formatter on non-distr data * remove time import (cherry picked from commit 3082dd9)
|
Backport failed for |
ClaudiaComito
added a commit
that referenced
this pull request
Jan 21, 2025
* make 1-proc print great again * fix tabs size * skip formatter on non-distr data * remove time import (cherry picked from commit 3082dd9) Co-authored-by: Claudia Comito <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due Diligence
benchmarks: created for new functionalitydoes not applyDescription
I noticed that printing out moderately large DNDarrays in non-distributed mode (i.e. interactive session or split=None) takes a disproportionate amount of time (see below) compared to printing the underlying tensor. Culprit is the
Formattercall.I've changed the printing module to bypass
Formatterif the input dndarray is not distributed. Torch takes care of the data formatting, tests pass.Example:
On 1 process:
mainbranch: 84 secondsthis PR: 0.01 seconds
Issue/s resolved: #
Changes proposed:
Type of change
Memory requirements
NA
Performance
see above
Does this change modify the behaviour of other functions? If so, which?
no