Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise Error for batched vector inputs on matmul #1646

Conversation

FOsterfeld
Copy link
Member

@FOsterfeld FOsterfeld commented Sep 12, 2024

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • benchmarks: created for new functionality
    • benchmarks: performance improved or maintained
    • documentation updated where needed

Description

Issue/s resolved: #1645

Changes proposed:

Type of change

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

yes / no

@FOsterfeld FOsterfeld linked an issue Sep 12, 2024 that may be closed by this pull request
Copy link
Contributor

Thank you for the PR!

@FOsterfeld FOsterfeld requested review from mtar and mrfh92 September 12, 2024 10:17
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.13%. Comparing base (b929c74) to head (7b110f0).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1646   +/-   ##
=======================================
  Coverage   92.12%   92.13%           
=======================================
  Files          83       83           
  Lines       12163    12165    +2     
=======================================
+ Hits        11205    11208    +3     
+ Misses        958      957    -1     
Flag Coverage Δ
unit 92.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Thank you for the PR!

@ClaudiaComito ClaudiaComito added this to the 1.5.0 milestone Oct 1, 2024
@ClaudiaComito ClaudiaComito added the bug Something isn't working label Oct 1, 2024
Copy link
Collaborator

@mrfh92 mrfh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!
Thanks @FOsterfeld for this and your previous work :)

@mrfh92 mrfh92 merged commit e1a36a7 into main Oct 4, 2024
43 checks passed
@mrfh92 mrfh92 deleted the 1645-bug-batched-matrix-vector-multiplication-does-not-work-correctly branch October 4, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working linalg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Batched Matrix-Vector Multiplication does not work correctly
3 participants