Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1085: Convolve with distributed kernel on multiple GPUs #1095

Merged
merged 4 commits into from
Feb 27, 2023
Merged

Fix #1085: Convolve with distributed kernel on multiple GPUs #1095

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6753aa2
changed to Bcast
shahpratham Feb 8, 2023
ecd23b1
clone tensor before Bcast
mtar Feb 24, 2023
be4e9b8
Merge branch 'main' into bug/1085-bcast-gpu
mtar Feb 24, 2023
10437b1
Merge branch 'main' into bug/1085-bcast-gpu
mtar Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion heat/core/signal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,8 @@ def convolve(a: DNDarray, v: DNDarray, mode: str = "full") -> DNDarray:
size = v.comm.size

for r in range(size):
rec_v = v.comm.bcast(t_v, root=r)
rec_v = t_v.clone()
v.comm.Bcast(rec_v, root=r)
t_v1 = rec_v.reshape(1, 1, rec_v.shape[0])
local_signal_filtered = fc.conv1d(signal, t_v1)
# unpack 3D result into 1D
Expand Down