Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate portion of test_squeeze() testing uneven tensor distribution across ranks #273

Closed
ClaudiaComito opened this issue May 23, 2019 · 1 comment
Closed

Reinstate portion of test_squeeze() testing uneven tensor distribution across ranks #273

ClaudiaComito opened this issue May 23, 2019 · 1 comment
Assignees
@ClaudiaComito
Labels
reduction operators Operators for calculations that reduce tensor dimension(s)

Comments

@ClaudiaComito
Copy link
Contributor

ClaudiaComito commented May 23, 2019 •
edited
Loading

In test_manipulations.test_squeeze(), the "4D split tensor" test is commented out, as it leads to uneven distribution of columns across the ranks (PR #231).

Solution: in manipulations.squeeze() replace Allgather with Allgatherv, specify "displs" argument (see link below). This will be possible with the upcoming Allgatherv update (Issue #233).

MPI_Allgatherv standard doc:
https://www.mpich.org/static/docs/latest/www3/MPI_Allgatherv.html
@ClaudiaComito ClaudiaComito self-assigned this May 23, 2019
@ClaudiaComito ClaudiaComito added the reduction operators Operators for calculations that reduce tensor dimension(s) label May 23, 2019
ClaudiaComito added a commit that referenced this issue May 23, 2019
@ClaudiaComito
Referenced relevant issues #273, #233
0ad2e5f
@ClaudiaComito ClaudiaComito mentioned this issue May 23, 2019
Merged
ClaudiaComito added a commit that referenced this issue May 27, 2019
@ClaudiaComito
Mentioning known issues #273, #233 that will be addressed separately.
59f2cc2
@ClaudiaComito ClaudiaComito mentioned this issue Jan 20, 2020
Closed
@ClaudiaComito ClaudiaComito mentioned this issue Apr 27, 2020
Merged
4 tasks
@ClaudiaComito
Copy link
Contributor Author

Unnecessary after merging #562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ClaudiaComito ClaudiaComito

Labels
reduction operators Operators for calculations that reduce tensor dimension(s)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ClaudiaComito