Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vals version #103

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Fix vals version #103

merged 1 commit into from
Oct 20, 2022

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Oct 8, 2022

Fix #96

Use the ldflags from goreleaser.

    # Custom ldflags templates.
    # Default is `-s -w -X main.version={{.Version}} -X main.commit={{.Commit}} -X main.date={{.Date}} -X main.builtBy=goreleaser`.
    ldflags:

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mumoshu mumoshu merged commit c15c774 into helmfile:main Oct 20, 2022
@jkroepke jkroepke deleted the fix-version branch January 1, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vals version does not work
2 participants