Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement - SSM Version Support #25

Closed
terrancej opened this issue May 11, 2020 · 4 comments
Closed

Enhancement - SSM Version Support #25

terrancej opened this issue May 11, 2020 · 4 comments

Comments

@terrancej
Copy link
Contributor

terrancej commented May 11, 2020

I would like to be able to choose the version of a SSM parameter. Such that:
ref+awsssm://PATH/TO/PARAM[?region=REGION][?version=VERSION]

Creating a PR for this

@terrancej
Copy link
Contributor Author

I'll update the README.

@mumoshu thoughts on
https://github.com/variantdev/vals/blob/a611e82bc24b845fa97953bfdc728749bc06083b/pkg/providers/ssm/ssm.go#L59 &
https://github.com/variantdev/vals/blob/a611e82bc24b845fa97953bfdc728749bc06083b/pkg/providers/ssm/ssm.go#L99

I was testing on my local Helmfile with the updated vals and I get the following. I'd love to suppress the output. I see that some other providers don't have a log line but maybe there is value in being able to see the value being pulled. I just don't want credentials in my CI logs

# tail from helmfile template
...
Deleting outdated charts

foo.yaml: basePath=.

hook[prepare] logs | namespace/foo unchanged
hook[prepare] logs | 
SSM: successfully retrieved key=bar

@mumoshu
Copy link
Collaborator

mumoshu commented May 13, 2020

@terrancej Thanks! I'm trying to isolate the cause. Are you giving helmfile a --log-level=debug flag?

@mumoshu
Copy link
Collaborator

mumoshu commented Feb 5, 2023

I've realized that SSM: successfully retrieved key=bar is logged vals and I made it togglable via a variable in #120.
Perhaps we can set the variable from helmfile or add a field to the vals runtime struct for toggling and set it from helmfile to suppress the logs.

mumoshu added a commit that referenced this issue Feb 5, 2023
mumoshu added a commit that referenced this issue Feb 5, 2023
@mumoshu
Copy link
Collaborator

mumoshu commented Mar 10, 2023

The fix is going to be live via v0.23.0!

@mumoshu mumoshu closed this as completed Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants