Use .cjs extension instead of package.json for CJS export

helmetjs · Mar 26, 2023 · dfb2ee7 · dfb2ee7
1 parent e2ef9d8
commit dfb2ee7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 10 deletions.
diff --git a/.npmignore b/.npmignore
@@ -8,7 +8,6 @@
 !README.md
 !SECURITY.md
 
-!dist/cjs/cjs.js
-!dist/cjs/package.json
+!dist/cjs/cjs.cjs
 !dist/esm/esm.js
 !dist/**/*.d.ts
diff --git a/bin/build-helmet.js b/bin/build-helmet.js
@@ -14,7 +14,7 @@ const esmDistPath = path.join(esmDistDir, "esm.js");
 const esmTypesTempPath = path.join(esmDistDir, "tmp-esm-index.d.ts");
 const esmTypesDistPath = path.join(esmDistDir, "esm.d.ts");
 const commonJsDistDir = path.join(distPath, "cjs");
-const commonJsDistPath = path.join(commonJsDistDir, "cjs.js");
+const commonJsDistPath = path.join(commonJsDistDir, "cjs.cjs");
 const commonJsTypesTempPath = path.join(
   commonJsDistDir,
   "tmp-commonjs-index.d.ts"
@@ -48,11 +48,6 @@ const compileCommonjs = () =>
       }
     );
 
-    await fs.writeFile(
-      path.join(commonJsDistDir, "package.json"),
-      JSON.stringify({ type: "commonjs" })
-    );
-
     await fs.rename(commonJsTypesTempPath, commonJsTypesDistPath);
   });
 

diff --git a/package.json b/package.json
@@ -56,13 +56,13 @@
   },
   "license": "MIT",
   "type": "module",
-  "main": "./dist/cjs/cjs.js",
+  "main": "./dist/cjs/cjs.cjs",
   "module": "./dist/esm/esm.js",
   "types": "./dist/esm/esm.d.ts",
   "exports": {
     ".": {
       "import": "./dist/esm/esm.js",
-      "require": "./dist/cjs/cjs.js",
+      "require": "./dist/cjs/cjs.cjs",
       "types": "./dist/esm/esm.d.ts"
     }
   }