-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: disable values schema validation for charts including a values.schema.json file #10398
Comments
Running into this issue now. A helm chart im using has a |
This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs. |
(Just bumping so the stale bot doesn't close this feature request!) |
This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs. |
(Not stale) |
Would love to see this implemented |
As a developer of charts with linked values schemas I would also want to not prevent my users from failing to install the script when not having internet connection. 👍 for this feature request. |
Hello, |
This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs. |
Can we get a maintainer to review #11510 for integration? |
Joe is on vacation - VacationBot |
is there any progress on this? In air-gapped evironments this can be crucial. |
We've made an in-CI workaround by fetching the chart to our CI agent, inflating it, renaming the json schema file, and then running the helm upgrade with the local chart path rather than the remote. |
…rade' and 'lint' When --skip-schema-valdiation is set, any schema contain in the helm chart is ignored. Defaults to 'false'. Closes helm#10398
…rade' and 'lint' When --skip-schema-validation is set, any schema contain in the helm chart is ignored. Defaults to 'false'. Closes helm#10398
…rade' and 'lint' When --skip-schema-validation is set, any schema contain in the helm chart is ignored. Defaults to 'false'. Closes helm#10398 Signed-off-by: anessi <[email protected]>
…rade' and 'lint' When --skip-schema-validation is set, any schema contain in the helm chart is ignored. Defaults to 'false'. Closes helm#10398 Signed-off-by: anessi <[email protected]>
…rade' and 'lint' When --skip-schema-validation is set, any schema contain in the helm chart is ignored. Defaults to 'false'. Closes helm#10398 Signed-off-by: anessi <[email protected]>
I have created a merge request (#12743) that solves this issue, including tests and doc updates. However, it seems to be really hard to get hold of a maintainer to look into it. I have mentioned it on the #helm-dev slack channel, but no luck. I will try again, but maybe you can vote on the PR if you want to see this fixed. |
@anessi it looks like your PR got approved! I would love to have this merged in (bumped up against this myself earlier). Do you need any help rebasing or anything? |
@tthornton3-chwy : I'd love to merge, but I don't have write permissions, so depend on the maintainers to merge it. |
…rade' and 'lint' When --skip-schema-validation is set, any schema contain in the helm chart is ignored. Defaults to 'false'. Closes helm#10398 Signed-off-by: anessi <[email protected]>
…rade' and 'lint' When --skip-schema-validation is set, any schema contain in the helm chart is ignored. Defaults to 'false'. Closes helm#10398 Signed-off-by: anessi <[email protected]>
It would be great if schema validation could be set to warn rather than skipped... but it'll do... |
Even when a chart designer/maintainer has decided to include a
values.schema.json
file in the Helm chart he/she releases it could be that the user of that chart (using it directly or as a dependency in an integration/umbrella Helm chart) cannot assure to fulfill the defined schema for the deployment specific values passed to that subchart (e.g. he/she passes a deployment specific values.yaml file to thehelm install/upgrade
command applied on that chart, where some "old" Helm parameter removed from thevalues.schema.json
of a newer version of that (sub)chart still remains).I think it would be useful to support a new option in
helm install
,helm upgrade
,helm lint
andhelm template
allowing to disable the values schema validation (in case avalues.schema.json
file is packaged in the target Helm chart or some listed subchart)The text was updated successfully, but these errors were encountered: