Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: disable values schema validation for charts including a values.schema.json file #10398

Closed
antaloala opened this issue Nov 24, 2021 · 17 comments · Fixed by #12743
Closed
Labels
feature good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. in progress

Comments

@antaloala
Copy link

antaloala commented Nov 24, 2021

Even when a chart designer/maintainer has decided to include a values.schema.json file in the Helm chart he/she releases it could be that the user of that chart (using it directly or as a dependency in an integration/umbrella Helm chart) cannot assure to fulfill the defined schema for the deployment specific values passed to that subchart (e.g. he/she passes a deployment specific values.yaml file to the helm install/upgrade command applied on that chart, where some "old" Helm parameter removed from the values.schema.json of a newer version of that (sub)chart still remains).

I think it would be useful to support a new option in helm install, helm upgrade, helm lint and helm template allowing to disable the values schema validation (in case a values.schema.json file is packaged in the target Helm chart or some listed subchart)

@the-scott-hand
Copy link

Running into this issue now. A helm chart im using has a values.schema.json which points to a git repo for some of the values, which unfortunately means I cant helm install the chart without an internet connection unless I untar the helm chart, remove the schema file, and then install. Would be interested in a flag like --skip-validation where it does the equivalent of not having the schema file in the chart. Does a flag like this exist?

@github-actions
Copy link

This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the Stale label May 18, 2022
@jedcunningham
Copy link

(Just bumping so the stale bot doesn't close this feature request!)

@github-actions
Copy link

This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Aug 17, 2022
@jedcunningham
Copy link

(Not stale)

@github-actions github-actions bot removed the Stale label Aug 18, 2022
@Salec
Copy link

Salec commented Sep 9, 2022

Would love to see this implemented

@lubojr
Copy link

lubojr commented Oct 21, 2022

As a developer of charts with linked values schemas I would also want to not prevent my users from failing to install the script when not having internet connection. 👍 for this feature request.

@joejulian joejulian added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Oct 22, 2022
@JvD-Ericsson
Copy link
Contributor

Hello,
I made an attempt to solve this problem. This is my first time contributing so, please let me know if anything is wrong so I can fix.

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.

@zswanson
Copy link

Can we get a maintainer to review #11510 for integration?
@joejulian ?

@joejulian
Copy link
Contributor

Joe is on vacation - VacationBot

@michbeck100
Copy link

is there any progress on this? In air-gapped evironments this can be crucial.

@zswanson
Copy link

zswanson commented Sep 6, 2023

We've made an in-CI workaround by fetching the chart to our CI agent, inflating it, renaming the json schema file, and then running the helm upgrade with the local chart path rather than the remote.
Its ugly and I hate it.

anessi added a commit to anessi/helm that referenced this issue Jan 23, 2024
…rade' and 'lint'

When --skip-schema-valdiation is set, any schema contain in the helm chart is ignored. Defaults to 'false'.

Closes helm#10398
anessi added a commit to anessi/helm that referenced this issue Jan 23, 2024
…rade' and 'lint'

When --skip-schema-validation is set, any schema contain in the helm chart is ignored. Defaults to 'false'.

Closes helm#10398
anessi added a commit to anessi/helm that referenced this issue Jan 23, 2024
…rade' and 'lint'

When --skip-schema-validation is set, any schema contain in the helm chart is ignored. Defaults to 'false'.

Closes helm#10398

Signed-off-by: anessi <[email protected]>
rohantmp pushed a commit to loft-sh/helm that referenced this issue Feb 5, 2024
…rade' and 'lint'

When --skip-schema-validation is set, any schema contain in the helm chart is ignored. Defaults to 'false'.

Closes helm#10398

Signed-off-by: anessi <[email protected]>
rohantmp pushed a commit to loft-sh/helm that referenced this issue Feb 5, 2024
…rade' and 'lint'

When --skip-schema-validation is set, any schema contain in the helm chart is ignored. Defaults to 'false'.

Closes helm#10398

Signed-off-by: anessi <[email protected]>
@anessi
Copy link
Contributor

anessi commented Mar 25, 2024

I have created a merge request (#12743) that solves this issue, including tests and doc updates. However, it seems to be really hard to get hold of a maintainer to look into it. I have mentioned it on the #helm-dev slack channel, but no luck. I will try again, but maybe you can vote on the PR if you want to see this fixed.

@tthornton3-chwy
Copy link

@anessi it looks like your PR got approved! I would love to have this merged in (bumped up against this myself earlier). Do you need any help rebasing or anything?

@anessi
Copy link
Contributor

anessi commented May 2, 2024

@anessi it looks like your PR got approved! I would love to have this merged in (bumped up against this myself earlier). Do you need any help rebasing or anything?

@tthornton3-chwy : I'd love to merge, but I don't have write permissions, so depend on the maintainers to merge it.
I will leave a comment on the merge request.

anessi added a commit to anessi/helm that referenced this issue Jun 25, 2024
…rade' and 'lint'

When --skip-schema-validation is set, any schema contain in the helm chart is ignored. Defaults to 'false'.

Closes helm#10398

Signed-off-by: anessi <[email protected]>
anessi added a commit to anessi/helm that referenced this issue Jun 25, 2024
…rade' and 'lint'

When --skip-schema-validation is set, any schema contain in the helm chart is ignored. Defaults to 'false'.

Closes helm#10398

Signed-off-by: anessi <[email protected]>
@portswigger-tim
Copy link

It would be great if schema validation could be set to warn rather than skipped... but it'll do...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. in progress
Projects
None yet