Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/nginx-ingress] Update nginx-ingress README for deprecation #22823

Merged
merged 2 commits into from
Aug 19, 2020
Merged

[stable/nginx-ingress] Update nginx-ingress README for deprecation #22823

merged 2 commits into from
Aug 19, 2020

Conversation

ChiefAlexander
Copy link
Collaborator

@ChiefAlexander ChiefAlexander commented Jun 16, 2020 •
edited by davidkarlsen
Loading

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 16, 2020
@k8s-ci-robot k8s-ci-robot requested review from lachie83 and taharah June 16, 2020 14:21
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2020
@ChiefAlexander ChiefAlexander mentioned this pull request Jun 16, 2020
Merged
4 tasks
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jun 16, 2020
@carrodher
Copy link
Collaborator

If the goal of this PR is fully deprecating the chart, there are other pending steps needed, you can take a look at the PROCESSES guide (or you can use a previous deprecation PR like #21415)

If it is just an informative note but not the definitive deprecation I think it's fine.

@stale
Copy link

stale bot commented Jul 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 18, 2020
@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 18, 2020
@davidkarlsen
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2020
@davidkarlsen davidkarlsen self-assigned this Jul 18, 2020
ChiefAlexander and others added 2 commits August 8, 2020 21:14
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 8, 2020
@davidkarlsen
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2020
@davidkarlsen davidkarlsen mentioned this pull request Aug 8, 2020
Closed
@davidkarlsen davidkarlsen self-requested a review August 8, 2020 19:24
@ChiefAlexander
Copy link
Collaborator Author

@lachie83 or @taharah could we get a review on this to get it merged in.

@ChiefAlexander ChiefAlexander mentioned this pull request Aug 13, 2020
Closed
4 tasks
@calvinbui
Copy link
Contributor

could a migration path be added similar to https://github.com/helm/charts/pull/21415/files#diff-179171755c7eed95fc128b80a12cb527 ?

either in this repo or the ingress-nginx repo with a link to it

@scottrigby
Copy link
Member

Cross referencing kubernetes/ingress-nginx#6038

scottrigby
scottrigby approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChiefAlexander, scottrigby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scottrigby scottrigby mentioned this pull request Aug 19, 2020
Merged
@k8s-ci-robot k8s-ci-robot merged commit d38b80b into helm:master Aug 19, 2020
This was referenced Aug 19, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@ChiefAlexander @davidkarlsen
[stable/nginx-ingress] Update nginx-ingress README for deprecation (h…
e951740 
…elm#22823)

* Update nginx-ingress README for deprecation

Signed-off-by: ChiefAlexander <[email protected]>

* add deprecation stuff

Signed-off-by: David Karlsen <[email protected]>

Co-authored-by: David Karlsen <[email protected]>
Signed-off-by: Miguel Mingorance <[email protected]>
@scottrigby scottrigby mentioned this pull request Jan 20, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scottrigby scottrigby scottrigby approved these changes

@lachie83 lachie83 Awaiting requested review from lachie83

@taharah taharah Awaiting requested review from taharah

@davidkarlsen davidkarlsen Awaiting requested review from davidkarlsen

Assignees

@davidkarlsen davidkarlsen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ChiefAlexander @carrodher @davidkarlsen @calvinbui @scottrigby @k8s-ci-robot @helm-bot