Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Fix default-backend-service doc #15868

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Fix default-backend-service doc #15868

merged 1 commit into from
Jul 25, 2019

Conversation

scuzhanglei
Copy link
Contributor

@scuzhanglei scuzhanglei commented Jul 25, 2019 •
edited
Loading

In fact, default-backend-service is not required. See 3126

What this PR does / why we need it:

fix doc error

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 25, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 25, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @scuzhanglei. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jul 25, 2019
@scuzhanglei
Update README.md
5ac99f0 
In fact,  default-backend-service is not required. See kubernetes/ingress-nginx#3126

Signed-off-by: zhanglei <[email protected]>
@ChiefAlexander
Copy link
Collaborator

Thanks for the doc update!
/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. ok-to-test labels Jul 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChiefAlexander, scuzhanglei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 05db816 into helm:master Jul 25, 2019
gypsydiver pushed a commit to gypsydiver/charts that referenced this pull request Jul 25, 2019
@scuzhanglei @gypsydiver
Update README.md (helm#15868)
c70eae5 
In fact,  default-backend-service is not required. See kubernetes/ingress-nginx#3126

Signed-off-by: zhanglei <[email protected]>
@scuzhanglei scuzhanglei deleted the patch-1 branch July 26, 2019 03:48
ThoTischner pushed a commit to bitsbeats/charts that referenced this pull request Aug 13, 2019
@scuzhanglei
Update README.md (helm#15868)
7039fd2 
In fact,  default-backend-service is not required. See kubernetes/ingress-nginx#3126

Signed-off-by: zhanglei <[email protected]>
landorg pushed a commit to landorg/charts that referenced this pull request Aug 19, 2019
@scuzhanglei @landorg
Update README.md (helm#15868)
4626609 
In fact,  default-backend-service is not required. See kubernetes/ingress-nginx#3126

Signed-off-by: zhanglei <[email protected]>
Signed-off-by: Roland Gritzer <[email protected]>
kengou pushed a commit to kengou/charts that referenced this pull request Sep 18, 2019
@scuzhanglei @kengou
Update README.md (helm#15868)
b79359b 
In fact,  default-backend-service is not required. See kubernetes/ingress-nginx#3126

Signed-off-by: zhanglei <[email protected]>
ramkumarvs pushed a commit to yugabyte/charts-helm-fork that referenced this pull request Sep 30, 2019
@scuzhanglei
Update README.md (helm#15868)
9cef133 
In fact,  default-backend-service is not required. See kubernetes/ingress-nginx#3126

Signed-off-by: zhanglei <[email protected]>
gaida pushed a commit to gaida/charts that referenced this pull request Oct 3, 2019
@scuzhanglei @gaida
Update README.md (helm#15868)
1fe112b 
In fact,  default-backend-service is not required. See kubernetes/ingress-nginx#3126

Signed-off-by: zhanglei <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChiefAlexander ChiefAlexander Awaiting requested review from ChiefAlexander

@taharah taharah Awaiting requested review from taharah

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scuzhanglei @k8s-ci-robot @ChiefAlexander @helm-bot