[stable/cluster-autoscaler] Use labels recommended by Helm

[rifelpet]

What this PR does / why we need it:

Updates the resources in cluster-autoscaler to use standard label keys recommended by helm.

See https://helm.sh/docs/chart_best_practices/#standard-labels

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

• N/A

Special notes for your reviewer:

Since the Deployment's selector is immutable, this is a breaking change and will require a deletion and recreation of the deployment, hence the major version bump.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• Variables are documented in the README.md
• Title of the PR starts with chart name (e.g. [stable/chart])

[k8s-ci-robot]

Hi @rifelpet. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[paulczar]

/ok-to-test

what does an upgrade from previous version look like? are there any special steps needed to deal with the changing labels?

[rifelpet]

The deployment's label selector is immutable, so a helm del --purge will be required prior to the helm upgrade. This means the cluster-autoscaler won't be running for that period of time.

[yurrriq]

@rifelpet, could you please resolve the Chart.yaml conflict, and mention the upgrade path in the README? With that in place, I'm fully supportive of this change.

You might also consider using some label helpers like I did here to DRY things up a bit.

[yurrriq]

/assign

[rifelpet]

@yurrriq the conflict has been resolved and the readme updated

[yurrriq]

/approve

[yurrriq]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet, yurrriq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stable/cluster-autoscaler/OWNERS [yurrriq]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yurrriq]

I'm new to this, but I think we're just waiting on prow to merge at this point.. Thanks, @rifelpet!